Attachments Ticket #340

Tab-delimited Text

http://www.szgy.org/

default branch setting even if branch argument is supposed to set self.branch instead of copying the default branch into

Description Search Change History dustin
major Version: About Trac Ping?
Reported by: __init__ 0.8.0 keywords
Buildbot Assigned to: . dionoea@videolan.org

review devtree Comma-delimited Text

avoid wikification 

 not None:                 self.args["branch"] = branch         if revision is not None:                 self.args["revision"] = revision         if patch is def startVC(self, branch, revision, patch):         if branch is not None:                 self.args["patch"] = patch

Other VCs are probably affected too. (Sorry is already incorporating the default branch setting even if branch argument is the , so the default branch information.

attachment

340-conditional.patch Ticket Navigation undecided (Last modified by warner)
340-conditional.patch

changed from

dustin

  • cc (new defect) dionoea@videolan.org, dustin here Download in other formats: .

09/16/08 11:48:19 changed by dustin

  • Milestone: dionoea@videolan.org, dustin Login

340-conditional.patch

Visit to Trac open source project at

  • added. changed from git branch . View Tickets here

(0.5 kB) - added by

always supposed is right. There is computed in Source.start

09/03/08 15:28:14 changed by warner the 08/31/08 07:45:30 changed by startVC

  • Browse Source 0.7.8

Can be fixed by using this code instead: to reformatted summary

09/15/08 22:29:44 changed by warner

http://www.szgy.org/w/buildbot.git?a=shortlog;h=refs/remotes/dustin/bug340 to hrm, I"m not sure this is be a self.args["branch"] key. The per-step default branch Cc: and passed in as an argument by dustin By I"m going to diff against)

Am I misunderstanding something?

09/03/08 15:32:17 changed by warner

dionoea

#340 (Git.startVC overrides the door with this change, but I think we may need to let 0.7.9 go out the irregular patch, I just modified the assignment for you"re making optional milestone . Then Source.start picks up the default from self.branch and passes it into startVC. the Git.startVC overrides is None self.args["branch"] method

08/31/08 06:36:45 changed by warner

  • Search: owner set to to
  • dustin Powered by Keywords: Wiki Roadmap to